Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

NumSeries() method for BlockReader interface #656

Closed
wants to merge 3 commits into from
Closed

NumSeries() method for BlockReader interface #656

wants to merge 3 commits into from

Conversation

codesome
Copy link
Contributor

This is a broken down piece of #627 and is required by #627.

@codesome
NumSeries() method for BlockReader interface
18e0f31 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
@codesome
Add CHANGELOG entry
29debd0 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
@codesome codesome mentioned this pull request Jul 10, 2019
Closed
@codesome
Use GaugeFunc for prometheus_tsdb_head_series
a0b9aec 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
@krasi-georgiev
Copy link
Contributor

the ReadOnly PR exposes the meta for the block and would cover your case as well.
#588

I was waiting for one final review, but if no one replies will merge in 1-2 days.

@codesome
Copy link
Contributor Author

#588 doesn't give NumSeries for head. So either a part of this PR would be needed or the Meta returned by Head needs to expose NumSeries.

@krasi-georgiev
Copy link
Contributor

yes I meant to add the NumSeries the read only db PR.

@codesome codesome mentioned this pull request Jul 16, 2019
Merged
@codesome
Copy link
Contributor Author

Closing this as its available as .Meta().NumSeries after #588 was merged.

@codesome codesome closed this Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gouthamve gouthamve gouthamve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codesome @krasi-georgiev @gouthamve